Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove changeReason and update CHANGES to prepare for 3.0.0 #819

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Remove changeReason and update CHANGES to prepare for 3.0.0 #819

merged 2 commits into from
Apr 16, 2021

Conversation

barm
Copy link
Collaborator

@barm barm commented Apr 16, 2021 •
edited
Loading

Description

Prepare for the 3.0.0 release. This will include the removal of changeReason in favor of _change_reason.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@barm barm force-pushed the update-to-3.0.0 branch from ad29576 to bff5afa Compare April 16, 2021 15:25
@barm barm linked an issue Apr 16, 2021 that may be closed by this pull request
Django 3.2 please bump release to support it (TextFields db_collation) #813
Closed
@barm barm mentioned this pull request Apr 16, 2021
Closed
@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited
Loading

Codecov Report

Merging #819 (4171603) into master (c888fcf) will increase coverage by 0.39%.
The diff coverage is n/a.

❗ Current head 4171603 differs from pull request most recent head 73dc358. Consider uploading reports for the commit 73dc358 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   97.47%   97.87%   +0.39%     
==========================================
  Files          18       18              
  Lines         992      988       -4     
  Branches      151      150       -1     
==========================================
  Hits          967      967              
+ Misses         12        9       -3     
+ Partials       13       12       -1
Impacted Files Coverage Δ
simple_history/utils.py 100.00% <ø> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c888fcf...73dc358. Read the comment docs.

@barm barm force-pushed the update-to-3.0.0 branch from bff5afa to f209854 Compare April 16, 2021 15:58
@barm barm requested a review from rossmechanic April 16, 2021 16:24
@barm barm force-pushed the update-to-3.0.0 branch from 4171603 to 725479a Compare April 16, 2021 16:38
@barm barm force-pushed the update-to-3.0.0 branch from 725479a to 73dc358 Compare April 16, 2021 16:38
@barm barm merged commit 67c7c43 into master Apr 16, 2021
@barm barm deleted the update-to-3.0.0 branch April 16, 2021 20:57
@ddabble ddabble added the release Pull requests that prepare for a new release label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePumpingLemma ThePumpingLemma ThePumpingLemma approved these changes

@rossmechanic rossmechanic Awaiting requested review from rossmechanic

Assignees
No one assigned
Labels
release Pull requests that prepare for a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 3.2 please bump release to support it (TextFields db_collation)
3 participants
@barm @ThePumpingLemma @ddabble